ui/base/models: convert usage of FOR_EACH_OBSERVER macro

ui/base/models/list_model.h

Index: ui/base/models/list_model.h
diff --git a/ui/base/models/list_model.h b/ui/base/models/list_model.h
index 877878461ae85a268601c50c4cd6eeb54e9afbc5..2194071dd1e04392d0df08ff5d20ccaec6cc3642 100644
--- a/ui/base/models/list_model.h
+++ b/ui/base/models/list_model.h
@@ -100,27 +100,23 @@ class ListModel {
   }
 
   void NotifyItemsAdded(size_t start, size_t count) {
-    FOR_EACH_OBSERVER(ListModelObserver,
-                      observers_,
-                      ListItemsAdded(start, count));
+    for (auto& observer : observers_)

[sky, 2016/10/13 02:23:08]

Why aren't we using auto* for all these? observers_ is an array of
listSModelObserver*.

[loyso (OOO), 2016/10/13 04:04:29]

FTR, the the original discussion (with explanation) here:
https://codereview.chromium.org/2414863002/patch/1/10001

[sky, 2016/10/13 17:07:31]

Please be explicit at the type names.

[tfarina, 2016/10/13 17:46:45]

Done. Sure, I also prefer explicit types rather than the type inference.

+      observer.ListItemsAdded(start, count);
   }
 
   void NotifyItemsRemoved(size_t start, size_t count) {
-    FOR_EACH_OBSERVER(ListModelObserver,
-                      observers_,
-                      ListItemsRemoved(start, count));
+    for (auto& observer : observers_)
+      observer.ListItemsRemoved(start, count);
   }
 
   void NotifyItemMoved(size_t index, size_t target_index) {
-    FOR_EACH_OBSERVER(ListModelObserver,
-                      observers_,
-                      ListItemMoved(index, target_index));
+    for (auto& observer : observers_)
+      observer.ListItemMoved(index, target_index);
   }
 
   void NotifyItemsChanged(size_t start, size_t count) {
-    FOR_EACH_OBSERVER(ListModelObserver,
-                      observers_,
-                      ListItemsChanged(start, count));
+    for (auto& observer : observers_)
+      observer.ListItemsChanged(start, count);
   }
 
   size_t item_count() const { return items_.size(); }