ui/base/models: convert usage of FOR_EACH_OBSERVER macro

ui/base/models: convert usage of FOR_EACH_OBSERVER macro

ObserverList now supports range-based for loops and thus this can be
used to iterate through a list of observers as the FOR_EACH_OBSERVER
macro was deprecated.

BUG=655021
TEST=ui_base_unittests
R=sky@chromium.org

Committed: https://crrev.com/b5319f19e04605ea292a54070d7065e53522d7b8
Cr-Commit-Position: refs/heads/master@{#425216}

[tfarina, 2016-10-13 00:48:43]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 00:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 01:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 01:35:49]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-13 02:23:08]

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h
File ui/base/models/list_model.h (right):

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h...
ui/base/models/list_model.h:103: for (auto& observer : observers_)
Why aren't we using auto* for all these? observers_ is an array of
listSModelObserver*.

[loyso (OOO), 2016-10-13 04:04:28]

loyso@chromium.org changed reviewers:
+ loyso@chromium.org

[loyso (OOO), 2016-10-13 04:04:29]

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h
File ui/base/models/list_model.h (right):

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h...
ui/base/models/list_model.h:103: for (auto& observer : observers_)
On 2016/10/13 02:23:08, sky wrote:
> Why aren't we using auto* for all these? observers_ is an array of
> listSModelObserver*.
FTR, the the original discussion (with explanation) here:
https://codereview.chromium.org/2414863002/patch/1/10001

[sky, 2016-10-13 17:07:31]

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h
File ui/base/models/list_model.h (right):

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h...
ui/base/models/list_model.h:103: for (auto& observer : observers_)
On 2016/10/13 04:04:29, loyso wrote:
> On 2016/10/13 02:23:08, sky wrote:
> > Why aren't we using auto* for all these? observers_ is an array of
> > listSModelObserver*.
> FTR, the the original discussion (with explanation) here:
> https://codereview.chromium.org/2414863002/patch/1/10001

Please be explicit at the type names.

[tfarina, 2016-10-13 17:39:09]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-10-13 17:46:45]

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h
File ui/base/models/list_model.h (right):

https://codereview.chromium.org/2414453006/diff/1/ui/base/models/list_model.h...
ui/base/models/list_model.h:103: for (auto& observer : observers_)
On 2016/10/13 17:07:31, sky wrote:
> On 2016/10/13 04:04:29, loyso wrote:
> > On 2016/10/13 02:23:08, sky wrote:
> > > Why aren't we using auto* for all these? observers_ is an array of
> > > listSModelObserver*.
> > FTR, the the original discussion (with explanation) here:
> > https://codereview.chromium.org/2414863002/patch/1/10001
> 
> Please be explicit at the type names.

Done. Sure, I also prefer explicit types rather than the type inference.

[commit-bot: I haz the power, 2016-10-13 18:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:35:09]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-14 00:01:16]

LGTM

[tfarina, 2016-10-14 00:28:40]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2016-10-14 00:29:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 00:36:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 00:40:21]

Description was changed from

==========
ui/base/models: convert usage of FOR_EACH_OBSERVER macro

ObserverList now supports range-based for loops and thus this can be
used to iterate through a list of observers as the FOR_EACH_OBSERVER
macro was deprecated.

BUG=655021
TEST=ui_base_unittests
R=sky@chromium.org
==========

to

==========
ui/base/models: convert usage of FOR_EACH_OBSERVER macro

ObserverList now supports range-based for loops and thus this can be
used to iterate through a list of observers as the FOR_EACH_OBSERVER
macro was deprecated.

BUG=655021
TEST=ui_base_unittests
R=sky@chromium.org

Committed: https://crrev.com/b5319f19e04605ea292a54070d7065e53522d7b8
Cr-Commit-Position: refs/heads/master@{#425216}
==========

[commit-bot: I haz the power, 2016-10-14 00:40:22]

Patchset 2 (id:??) landed as
https://crrev.com/b5319f19e04605ea292a54070d7065e53522d7b8
Cr-Commit-Position: refs/heads/master@{#425216}