Traverse PDF page tree only once in CPDF_Document

core/fpdfapi/parser/cpdf_document.h

Index: core/fpdfapi/parser/cpdf_document.h
diff --git a/core/fpdfapi/parser/cpdf_document.h b/core/fpdfapi/parser/cpdf_document.h
index c557a56013f71da4dc7106ad5faa97eb154c56ae..0fe3310e1124055ceece22c4598fc2da1c1a761e 100644
--- a/core/fpdfapi/parser/cpdf_document.h
+++ b/core/fpdfapi/parser/cpdf_document.h
@@ -9,6 +9,7 @@
 
 #include <functional>
 #include <memory>
+#include <stack>
 
 #include "core/fpdfapi/parser/cpdf_indirect_object_holder.h"
 #include "core/fpdfapi/parser/cpdf_object.h"
@@ -102,15 +103,15 @@ class CPDF_Document : public CPDF_IndirectObjectHolder {
                             FX_BOOL bTranslateName = FALSE);
 #endif
 
+  std::stack<std::pair<CPDF_Dictionary*, int>> m_pTreeTraversal;
+  int m_iLastPageTraversed;

[dsinclair, 2016/10/18 13:35:59]

Should these two members be private?

[npm, 2016/10/18 14:26:31]

Since I needed to reset them in namespace method InsertDeletePDFPage, I made
them public

+
  private:
   friend class CPDF_TestDocument;
 
   // Retrieve page count information by getting count value from the tree nodes
   int RetrievePageCount() const;
-  CPDF_Dictionary* FindPDFPage(CPDF_Dictionary* pPages,
-                               int iPage,
-                               int nPagesToGo,
-                               int level);
+  CPDF_Dictionary* TraversePDFPages(int iPage, int nPagesToGo);
   int FindPageIndex(CPDF_Dictionary* pNode,
                     uint32_t& skip_count,
                     uint32_t objnum,