Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2414373002: Revert of Improve CodeStubAssembler assert functionality (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Improve CodeStubAssembler assert functionality (patchset #3 id:40001 of https://codereview.chromium.org/2419433008/ ) Reason for revert: [Sheriff] Fails leak checker: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/12393 Original issue's description: > Improve CodeStubAssembler assert functionality > > Introduce CSA_ASSERT macro that outputs a message, file name and line number to > console before calling DebugBreak. > > Committed: https://crrev.com/23836e9c14f3df9b675fe02e2c23bb11e728b83d > Cr-Commit-Position: refs/heads/master@{#40307} TBR=epertoso@chromium.org,ishell@google.com,ishell@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0b260995c6f28a0f64d9b2c801c3119b3e3b82da Cr-Commit-Position: refs/heads/master@{#40313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -45 lines) Patch
M src/code-stub-assembler.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 15 chunks +21 lines, -40 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Improve CodeStubAssembler assert functionality
4 years, 2 months ago (2016-10-14 12:32:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414373002/1
4 years, 2 months ago (2016-10-14 12:32:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 12:32:21 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 12:32:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b260995c6f28a0f64d9b2c801c3119b3e3b82da
Cr-Commit-Position: refs/heads/master@{#40313}

Powered by Google App Engine
This is Rietveld 408576698