Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2414363002: tools: Extend the CustomTabs benchmark scripts to speculative_prefetch. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
droger
CC:
chromium-reviews, mikecase+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools: Extend the CustomTabs benchmark scripts to speculative_prefetch. This extends the Custom Tabs benchmark scripts to also be useful for speculative prefetch evaluation. Also a bunch of small cleanups (including making the linter happy). BUG=655980 Committed: https://crrev.com/a181b9af5728c5989e048fa51caf881e124e7c16 Cr-Commit-Position: refs/heads/master@{#425312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -117 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 2 chunks +3 lines, -1 line 0 comments Download
M tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java View 7 chunks +33 lines, -16 lines 0 comments Download
M tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py View 8 chunks +92 lines, -65 lines 0 comments Download
M tools/android/customtabs_benchmark/scripts/run_benchmark.py View 6 chunks +23 lines, -35 lines 0 comments Download
A tools/android/customtabs_benchmark/scripts/sample_config.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benoit L
4 years, 2 months ago (2016-10-14 12:25:47 UTC) #2
droger
lgtm
4 years, 2 months ago (2016-10-14 13:03:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414363002/1
4 years, 2 months ago (2016-10-14 13:41:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 13:46:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 13:48:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a181b9af5728c5989e048fa51caf881e124e7c16
Cr-Commit-Position: refs/heads/master@{#425312}

Powered by Google App Engine
This is Rietveld 408576698