Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2414343002: Implement MediaValues for initial viewport. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, kenneth.christiansen, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement MediaValues for initial viewport. Viewport-dependent media queries evaluate in the context of the initial viewport when collecting @viewport rules as specified in [1]. Implement a MediaValuesInitialViewport which returns the initial viewport dimensions instead of the actual viewport. This change doesn't fix issue 332763 until we start collecting author @viewport rules before creating RuleSets. [1] https://www.w3.org/TR/css-device-adapt-1/#media-queries R=timloh@chromium.org BUG=332763 Committed: https://crrev.com/cdb270396aeb667c46e53ed6df0c01fa8ddf4a74 Cr-Commit-Position: refs/heads/master@{#425628}

Patch Set 1 #

Patch Set 2 : CORE_EXPORT in inheritance chain for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -6 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaValuesDynamic.h View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/css/MediaValuesInitialViewport.h View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/MediaValuesInitialViewport.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/MediaValuesInitialViewportTest.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/viewport-inside-media.html View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rune
ptal
4 years, 2 months ago (2016-10-14 14:41:49 UTC) #9
Timothy Loh
lgtm
4 years, 2 months ago (2016-10-17 03:54:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414343002/20001
4 years, 2 months ago (2016-10-17 06:30:27 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 07:48:16 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 07:49:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdb270396aeb667c46e53ed6df0c01fa8ddf4a74
Cr-Commit-Position: refs/heads/master@{#425628}

Powered by Google App Engine
This is Rietveld 408576698