Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

Issue 2414333003: WebMessaging: Send transferable ArrayBuffers by copy-and-neuter semantics (Closed)
Patch Set: fix tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
index 9b94241ee2b3bbf7477bb60759d70920e5fcc285..7816a935aacd11cffeb2fdd8ba19fd03a9ed8e9d 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
@@ -8,7 +8,6 @@
#include "bindings/core/v8/CallbackPromiseAdapter.h"
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/SerializedScriptValue.h"
-#include "core/inspector/ConsoleMessage.h"
#include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
#include "public/platform/WebString.h"
#include "wtf/RefPtr.h"
@@ -74,12 +73,6 @@ void ServiceWorkerClient::postMessage(ExecutionContext* context,
if (exceptionState.hadException())
return;
- if (message->containsTransferableArrayBuffer())
- context->addConsoleMessage(ConsoleMessage::create(
- JSMessageSource, WarningMessageLevel,
- "ServiceWorkerClient cannot send an ArrayBuffer as a transferable "
- "object yet. See http://crbug.com/511119"));
-
WebString messageString = message->toWireString();
std::unique_ptr<WebMessagePortChannelArray> webChannels =
MessagePort::toWebMessagePortChannelArray(std::move(channels));
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698