Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2414333002: Set 32-bit ABI flag in WebView manifest. (Closed)

Created:
4 years, 2 months ago by Torne
Modified:
4 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set 32-bit ABI flag in WebView manifest. In multiprocess mode we currently want to run WebView renderers as 32-bit on 64-bit devices for memory savings. This is already the case for Monochrome, but the standalone WebView was not setting the appropriate flag in its manifest; add it here. BUG=655160 Committed: https://crrev.com/d9afdaaf5198350a06c484e4b7fbb3de50e3914a Cr-Commit-Position: refs/heads/master@{#425288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/apk/java/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
This brings WebView in line with monochrome such that the renderers will get started as ...
4 years, 2 months ago (2016-10-14 09:51:46 UTC) #2
Tobias Sargeant
lgtm
4 years, 2 months ago (2016-10-14 09:55:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414333002/1
4 years, 2 months ago (2016-10-14 09:56:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 10:21:05 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 10:23:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9afdaaf5198350a06c484e4b7fbb3de50e3914a
Cr-Commit-Position: refs/heads/master@{#425288}

Powered by Google App Engine
This is Rietveld 408576698