Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2414303002: Remove usage of FOR_EACH_OBSERVER macro in ash/common (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ash/common Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1 Cr-Commit-Position: refs/heads/master@{#425443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -122 lines) Patch
M ash/common/shelf/shelf_background_animator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/common/shelf/shelf_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M ash/common/shelf/shelf_model.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M ash/common/shelf/wm_shelf.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/network/vpn_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/chromeos/power/power_status.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/tray/system_tray_notifier.cc View 19 chunks +66 lines, -61 lines 0 comments Download
M ash/common/wallpaper/wallpaper_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/dock/docked_window_layout_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/window_state.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/wm_shell.cc View 3 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-14 06:50:07 UTC) #6
Daniel Erat
lgtm
4 years, 2 months ago (2016-10-14 15:21:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414303002/1
4 years, 2 months ago (2016-10-14 19:55:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 20:08:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 20:10:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1
Cr-Commit-Position: refs/heads/master@{#425443}

Powered by Google App Engine
This is Rietveld 408576698