Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2414293002: Deprecates --spdy_framer_use_new_methods4. (Closed)

Created:
4 years, 2 months ago by diannahu
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecates --spdy_framer_use_new_methods4. Also adds and modifies code, especially tests, to match their server-side analogues. This CL lands server change 135477642 by birenroy. BUG=488484 Committed: https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846 Cr-Commit-Position: refs/heads/master@{#425509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -264 lines) Patch
M net/spdy/mock_spdy_framer_visitor.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/spdy/mock_spdy_framer_visitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_deframer_visitor_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/spdy/spdy_framer.cc View 10 chunks +44 lines, -60 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.cc View 2 chunks +1 line, -6 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 8 chunks +131 lines, -181 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
diannahu
Some changes in this CL (and maybe later CLs) will be backported in server-side change ...
4 years, 2 months ago (2016-10-14 17:22:19 UTC) #6
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-10-14 19:33:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414293002/1
4 years, 2 months ago (2016-10-14 23:30:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 23:35:59 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 23:38:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846
Cr-Commit-Position: refs/heads/master@{#425509}

Powered by Google App Engine
This is Rietveld 408576698