Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2414273002: Fix StringToDouble parsing for large exponent (Closed)

Created:
4 years, 2 months ago by kcwu
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix StringToDouble parsing for large exponent 1. strtod() need to maintain |end| pointer, should not stop immediately when detected overflow 2. It is possible the the exponent is larger than max-exponent, but combined with mantissa, the final value is within the range of double. This CL mitigate this issue (use INT_MAX instead), to make it possible to parse values near the max/min double boundaries. found by libfuzzer TEST=base_unittest --gtest_filter=StringNumberConversionsTest.* BUG=542881 Committed: https://crrev.com/094232aa420680ea0c8b4bb5e465315bd5972c2f Cr-Commit-Position: refs/heads/master@{#425501}

Patch Set 1 : Fix StringToDouble parsing for large exponent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M base/strings/string_number_conversions_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/dmg_fp/dtoa.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/third_party/dmg_fp/exp_length.patch View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
kcwu
4 years, 2 months ago (2016-10-14 04:46:33 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-14 22:52:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414273002/20001
4 years, 2 months ago (2016-10-14 22:53:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414273002/20001
4 years, 2 months ago (2016-10-14 22:53:49 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-14 22:58:58 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 23:02:59 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/094232aa420680ea0c8b4bb5e465315bd5972c2f
Cr-Commit-Position: refs/heads/master@{#425501}

Powered by Google App Engine
This is Rietveld 408576698