Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2414263002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange (Closed)
Patch Set: Patched in copy/paste Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index 6234fcd4d0646a20a47a6f8b52f45a47e70962c5..bc2f7358acf3330626b29253f26ab437e8d9c4bd 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -991,14 +991,14 @@ bool SpellChecker::selectionStartHasSpellingMarkerFor(int from,
void SpellChecker::removeMarkers(const VisibleSelection& selection,
DocumentMarker::MarkerTypes markerTypes) {
- const EphemeralRange range = selection.toNormalizedEphemeralRange();
- if (range.isNull())
- return;
-
// TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
// needs to be audited. See http://crbug.com/590369 for more details.
frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+ const EphemeralRange range = selection.toNormalizedEphemeralRange();
yosin_UTC9 2016/10/14 08:13:00 s/const EphemeralRange/const EphemeralRange&/
Xiaocheng 2016/10/14 08:35:14 Done.
+ if (range.isNull())
+ return;
+
frame().document()->markers().removeMarkers(range, markerTypes);
}

Powered by Google App Engine
This is Rietveld 408576698