Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2414213002: MD Settings: use theme homepage URLs when set (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: use theme homepage URLs when set R=dpapad@chromium.org BUG=632376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1f2f534bbcf83f1a54d35bad3345e3b181da71ba Cr-Commit-Position: refs/heads/master@{#425227}

Patch Set 1 #

Patch Set 2 : ensure always CWS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 1 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Dan Beam
4 years, 2 months ago (2016-10-13 23:32:45 UTC) #2
dpapad
lgtm
4 years, 2 months ago (2016-10-14 00:37:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414213002/20001
4 years, 2 months ago (2016-10-14 01:09:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 01:16:00 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 01:19:29 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f2f534bbcf83f1a54d35bad3345e3b181da71ba
Cr-Commit-Position: refs/heads/master@{#425227}

Powered by Google App Engine
This is Rietveld 408576698