Check for the type of the the spawned function.

Check for the type of the the spawned function.

In general we avoid explicit type-checks, but in this case the error would be only detected in the new isolate making error handling much harder.

Fixes #27185
BUG= http://dartbug.com/27185.
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/136e476c870394d8fa7a777e97e95bb21382177a

[floitsch, 2016-10-14 09:52:55]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-10-14 10:13:56]

lgtm

https://codereview.chromium.org/2414173003/diff/1/runtime/lib/isolate_patch.dart
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/2414173003/diff/1/runtime/lib/isolate_patch.d...
runtime/lib/isolate_patch.dart:315: if (entryPoint is! _MainFunctionArgs) {
_MainFunctionArgs is not really the correct type name for this - this is just an
unary function, not a "main function".
If we ever change _MainFunctionArgs to check that the first parameter has type
List<String>, this will stop working.

Maybe just rename the typedefs to _NullaryFunction, _UnaryFunction and
_BinaryFunction, then it's clear what they are checking and what they aren't
checking.

https://codereview.chromium.org/2414173003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/2414173003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:13: typedef
_SingleArgumentFunction(arg);
Just _UnaryFunction.

[floitsch, 2016-10-14 11:25:42]

https://codereview.chromium.org/2414173003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/2414173003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:13: typedef
_SingleArgumentFunction(arg);
On 2016/10/14 10:13:56, Lasse Reichstein Nielsen wrote:
> Just _UnaryFunction.

Done.

[floitsch, 2016-10-14 11:25:59]

https://codereview.chromium.org/2414173003/diff/1/runtime/lib/isolate_patch.dart
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/2414173003/diff/1/runtime/lib/isolate_patch.d...
runtime/lib/isolate_patch.dart:315: if (entryPoint is! _MainFunctionArgs) {
On 2016/10/14 10:13:56, Lasse Reichstein Nielsen wrote:
> _MainFunctionArgs is not really the correct type name for this - this is just
an
> unary function, not a "main function".
> If we ever change _MainFunctionArgs to check that the first parameter has type
> List<String>, this will stop working.
> 
> Maybe just rename the typedefs to _NullaryFunction, _UnaryFunction and
> _BinaryFunction, then it's clear what they are checking and what they aren't
> checking.

Done.

[floitsch, 2016-10-14 11:27:16]

Description was changed from

==========
Check for the type of the the spawned function.

In general we avoid explicit type-checks, but in this case the error would be
only detected in the new isolate making error handling much harder.

Fixes #27185
BUG= http://dartbug.com/27185.
==========

to

==========
Check for the type of the the spawned function.

In general we avoid explicit type-checks, but in this case the error would be
only detected in the new isolate making error handling much harder.

Fixes #27185
BUG= http://dartbug.com/27185.
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/136e476c870394d8fa7a777e97e95bb21382177a
==========

[floitsch, 2016-10-14 11:27:18]

Committed patchset #2 (id:20001) manually as
136e476c870394d8fa7a777e97e95bb21382177a (presubmit successful).