[System Health] Make pinterest/tumblr stories scroll to elements off screen.

tools/perf/page_sets/system_health/browsing_stories.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from page_sets.system_health import platforms
 from page_sets.system_health import system_health_story
 
 from page_sets.login_helpers import pinterest_login
 
 from telemetry import decorators
@@ skipping 11 matching lines @@
   ITEM_SELECTOR = NotImplemented
   ABSTRACT_STORY = True
 
   def _WaitForNavigation(self, action_runner):
     if not self.IS_SINGLE_PAGE_APP:
       action_runner.WaitForNavigate()
 
   def _NavigateToItem(self, action_runner, index):
     item_selector = 'document.querySelectorAll("%s")[%d]' % (
         self.ITEM_SELECTOR, index)
+    # Only scrolls if element is not currently in viewport.
+    action_runner.ScrollPageToElement(element_function=item_selector)
     self._ClickLink(action_runner, item_selector)
 
   def _ClickLink(self, action_runner, element_function):
     action_runner.WaitForElement(element_function=element_function)
     action_runner.ClickElement(element_function=element_function)
     self._WaitForNavigation(action_runner)
 
   def _NavigateBack(self, action_runner):
     action_runner.ExecuteJavaScript('window.history.back()')
     self._WaitForNavigation(action_runner)
@@ skipping 228 matching lines @@
 
 class YouTubeMobileStory(_MediaBrowsingStory):
   NAME = 'browse:media:youtube'
   URL = 'https://m.youtube.com/watch?v=QGfhS1hfTWw&autoplay=false'
   ITEM_SELECTOR = '._mhgb > a'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
   IS_SINGLE_PAGE_APP = True
   ITEM_SELECTOR_INDEX = 3
 
 
+# Failing during CQ runs. crbug.com/661775
+@decorators.Disabled('linux', 'win')
 class YouTubeDesktopStory(_MediaBrowsingStory):
   NAME = 'browse:media:youtube'
   URL = 'https://www.youtube.com/watch?v=QGfhS1hfTWw&autoplay=false'
   ITEM_SELECTOR = '.yt-uix-simple-thumb-related'
   SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
   IS_SINGLE_PAGE_APP = True
   # A longer view time allows videos to load and play.
   ITEM_VIEW_TIME_IN_SECONDS = 5
   ITEMS_TO_VISIT = 8
   ITEM_SELECTOR_INDEX = 3
@@ skipping 18 matching lines @@
   # theater viewer.
   SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS
   IS_SINGLE_PAGE_APP = True
 
 
 class TumblrDesktopStory(_MediaBrowsingStory):
   NAME = 'browse:media:tumblr'
   URL = 'https://tumblr.com/search/gifs'
   ITEM_SELECTOR = '.photo'
   IS_SINGLE_PAGE_APP = True
-  ITEMS_TO_VISIT = 2  # Increase when crbug.com/651909 is implemented.
-  ITEM_VIEW_TIME_IN_SECONDS = 5
+  ITEMS_TO_VISIT = 8
   INCREMENT_INDEX_AFTER_EACH_ITEM = True
-  SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS  # crbug.com/651909.
+  SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
 
   def _ViewMediaItem(self, action_runner, index):
     super(TumblrDesktopStory, self)._ViewMediaItem(action_runner, index)
     action_runner.MouseClick(selector='#tumblr_lightbox_center_image')
-
+    action_runner.Wait(1)  # To make browsing more realistic.
 
 class PinterestDesktopStory(_MediaBrowsingStory):
   NAME = 'browse:media:pinterest'
   URL = 'https://pinterest.com'
   ITEM_SELECTOR = '.pinImageDim'
   IS_SINGLE_PAGE_APP = True
-  ITEMS_TO_VISIT = 5  # Increase when crbug.com/651909 is implemented.
-  ITEM_VIEW_TIME_IN_SECONDS = 5
+  ITEMS_TO_VISIT = 8
   INCREMENT_INDEX_AFTER_EACH_ITEM = True
   SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
 
   def _Login(self, action_runner):
     pinterest_login.LoginDesktopAccount(action_runner, 'googletest',
                                         self.credentials_path)
 
   def _ViewMediaItem(self, action_runner, index):
     super(PinterestDesktopStory, self)._ViewMediaItem(action_runner, index)
     # To imitate real user interaction, we do not want to pin every post.
@@ skipping 10 matching lines @@
       inner_save_function = 'document.querySelector(".nameAndIcons")'
       action_runner.WaitForElement(element_function=inner_save_function)
       action_runner.ClickElement(element_function=inner_save_function)
       action_runner.Wait(1)  # Wait to make navigation realistic.
 
     # Close selection.
     x_element_function = ('document.querySelector('
                           '".Button.borderless.close.visible")')
     action_runner.ClickElement(element_function=x_element_function)
     action_runner.Wait(1)  # Wait to make navigation realistic.