[System Health] Make pinterest/tumblr stories scroll to elements off screen.

tools/perf/page_sets/system_health/browsing_stories.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from page_sets.system_health import platforms
 from page_sets.system_health import system_health_story
 
 from page_sets.login_helpers import pinterest_login
 
 from telemetry import decorators
@@ skipping 11 matching lines @@
   ITEM_SELECTOR = NotImplemented
   ABSTRACT_STORY = True
 
   def _WaitForNavigation(self, action_runner):
     if not self.IS_SINGLE_PAGE_APP:
       action_runner.WaitForNavigate()
 
   def _NavigateToItem(self, action_runner, index):
     item_selector = 'document.querySelectorAll("%s")[%d]' % (
         self.ITEM_SELECTOR, index)
+    # Only scrolls if element is not currently in viewport.
+    action_runner.ScrollPageToElement(element_function=item_selector)
     self._ClickLink(action_runner, item_selector)
 
   def _ClickLink(self, action_runner, element_function):
     action_runner.WaitForElement(element_function=element_function)
     action_runner.ClickElement(element_function=element_function)
     self._WaitForNavigation(action_runner)
 
   def _NavigateBack(self, action_runner):
     action_runner.ExecuteJavaScript('window.history.back()')
     self._WaitForNavigation(action_runner)
@@ skipping 266 matching lines @@
   # theater viewer.
   SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS
   IS_SINGLE_PAGE_APP = True
 
 
 class TumblrDesktopStory(_MediaBrowsingStory):
   NAME = 'browse:media:tumblr'
   URL = 'https://tumblr.com/search/gifs'
   ITEM_SELECTOR = '.photo'
   IS_SINGLE_PAGE_APP = True
-  ITEMS_TO_VISIT = 2  # Increase when crbug.com/651909 is implemented.
+  ITEMS_TO_VISIT = 8

[rnephew (Reviews Here), 2016/10/14 22:52:52]

Should I just use the default 15 here?

[petrcermak, 2016/10/17 08:51:37]

Unless it makes the story too long or less stable, I don't see any reason to use
a custom value ;-)

[rnephew (Reviews Here), 2016/10/17 18:48:19]

After some local experimenting it does seem to make it less stable. I will set
it to 8 like the youtube set.

Tumblr will randomly try to open some images as pages and some as popups. Its a
low rate of occurance, but 15 seems to trigger it at least once every run.

The pinterest page crashes during clock sync when its set to 15. It does not
when set to 8 though, so I'm guessing this has something to do with the
length/size of the trace. 

   ITEM_VIEW_TIME_IN_SECONDS = 5
   INCREMENT_INDEX_AFTER_EACH_ITEM = True
-  SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS  # crbug.com/651909.
+  SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
 
   def _ViewMediaItem(self, action_runner, index):
     super(TumblrDesktopStory, self)._ViewMediaItem(action_runner, index)
     action_runner.MouseClick(selector='#tumblr_lightbox_center_image')
-
+    action_runner.Wait(1) # To make browsing more realistic.

[petrcermak, 2016/10/17 08:51:37]

nit: There should be two spaces before a comment.

[rnephew (Reviews Here), 2016/10/17 18:48:19]

Done.

 
 class PinterestDesktopStory(_MediaBrowsingStory):
   NAME = 'browse:media:pinterest'
   URL = 'https://pinterest.com'
   ITEM_SELECTOR = '.pinImageDim'
   IS_SINGLE_PAGE_APP = True
-  ITEMS_TO_VISIT = 5  # Increase when crbug.com/651909 is implemented.
+  ITEMS_TO_VISIT = 8
   ITEM_VIEW_TIME_IN_SECONDS = 5
   INCREMENT_INDEX_AFTER_EACH_ITEM = True
   SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
 
   def _Login(self, action_runner):
     pinterest_login.LoginDesktopAccount(action_runner, 'googletest',
                                         self.credentials_path)
 
   def _ViewMediaItem(self, action_runner, index):
     super(PinterestDesktopStory, self)._ViewMediaItem(action_runner, index)
@@ skipping 11 matching lines @@
       inner_save_function = 'document.querySelector(".nameAndIcons")'
       action_runner.WaitForElement(element_function=inner_save_function)
       action_runner.ClickElement(element_function=inner_save_function)
       action_runner.Wait(1)  # Wait to make navigation realistic.
 
     # Close selection.
     x_element_function = ('document.querySelector('
                           '".Button.borderless.close.visible")')
     action_runner.ClickElement(element_function=x_element_function)
     action_runner.Wait(1)  # Wait to make navigation realistic.