Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2414133003: Revert of Presubmit recipe: commit the patch (Closed)

Created:
4 years, 2 months ago by borenet
Modified:
4 years, 2 months ago
Reviewers:
borenet2, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Presubmit recipe: commit the patch (patchset #3 id:40001 of https://codereview.chromium.org/2398653002/ ) Reason for revert: Instead of trying to run the presubmit for try jobs and at every commit, let's do it only for try jobs, which worked fine without this CL. Original issue's description: > Presubmit recipe: call presubmit_support.py directly > > For some reason, presubmit_support.py can't find PRESUBMIT.py > unless it has a diff. Calling this script directly allows us > to specify a fake upstream to force it to find a diff and > therefore be able to find PRESUBMIT.py. > > BUG=skia:5823 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2398653002 > > Committed: https://skia.googlesource.com/skia/+/c1c7c21fdd2793b2c03b8ffc06461a00c4241a18 TBR=rmistry@google.com,borenet@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5823 Committed: https://skia.googlesource.com/skia/+/cd72afa8f19260ab231348083bf0ed51722240d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -15 lines) Patch
M infra/bots/recipes/swarm_presubmit.py View 1 chunk +25 lines, -12 lines 0 comments Download
M infra/bots/recipes/swarm_presubmit.expected/presubmit.json View 3 chunks +43 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
borenet
Created Revert of Presubmit recipe: commit the patch
4 years, 2 months ago (2016-10-14 03:33:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414133003/1
4 years, 2 months ago (2016-10-14 16:30:59 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot/builds/784)
4 years, 2 months ago (2016-10-14 16:43:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414133003/1
4 years, 2 months ago (2016-10-14 16:50:29 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:11:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd72afa8f19260ab231348083bf0ed51722240d7

Powered by Google App Engine
This is Rietveld 408576698