ash: Fix crash in launcher tooltip manager

ash/launcher/launcher_view.cc

Index: ash/launcher/launcher_view.cc
diff --git a/ash/launcher/launcher_view.cc b/ash/launcher/launcher_view.cc
index 57bcf26abb191d68acd2c55fdc38db837e3f556c..d7f4b092e8a4db5187384f1115574b13a777030e 100644
--- a/ash/launcher/launcher_view.cc
+++ b/ash/launcher/launcher_view.cc
@@ -477,7 +477,7 @@ void LauncherView::OnShelfAlignmentChanged() {
     if (i >= first_visible_index_ && i <= last_visible_index_)
       view_model_->view_at(i)->Layout();
   }
-  tooltip_->UpdateArrow();
+  tooltip_->Close();

[James Cook, 2013/09/13 23:54:09]

The fix below to close the tooltip when its launcher button is removed is
probably sufficient to fix the crash (it fixes the test I added to repro the
crash). However, it doesn't really make sense to keep tooltips open during shelf
alignment changes, so I just close them.

   if (overflow_bubble_)
     overflow_bubble_->Hide();
 }
@@ -1452,6 +1452,11 @@ void LauncherView::LauncherItemRemoved(int model_index, LauncherID id) {
                                   view_model_->view_size() - 1);
     UpdateOverflowRange(overflow_bubble_->launcher_view());
   }
+
+  // Close the tooltip because it isn't needed any longer and its anchor view
+  // will be deleted soon.
+  if (tooltip_->anchor() == view)
+    tooltip_->Close();
 }
 
 void LauncherView::LauncherItemChanged(int model_index,