Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2414093003: [tools] Fix merging sancov files from multiple test attempts (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Fix merging sancov files from multiple test attempts This differentiates sancov files from several runs of the same test. This situation happens when a test fails and is rerun for flake checking. BUG=v8:5502 Committed: https://crrev.com/7d2c514d845da6d15183bc500892d3812a86957e Cr-Commit-Position: refs/heads/master@{#40304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -38 lines) Patch
M tools/sanitizers/sancov_merger.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/sanitizers/sancov_merger_test.py View 2 chunks +33 lines, -33 lines 0 comments Download
M tools/testrunner/local/execution.py View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Achenbach
PTAL
4 years, 2 months ago (2016-10-14 09:02:28 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-14 09:03:53 UTC) #6
Michael Achenbach
The tons of test failures show that the problem I want to fix here is ...
4 years, 2 months ago (2016-10-14 09:32:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414093003/1
4 years, 2 months ago (2016-10-14 09:32:45 UTC) #9
tandrii(chromium)
lgtm
4 years, 2 months ago (2016-10-14 09:35:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 10:00:09 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 10:00:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d2c514d845da6d15183bc500892d3812a86957e
Cr-Commit-Position: refs/heads/master@{#40304}

Powered by Google App Engine
This is Rietveld 408576698