Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.cc

Issue 2414063002: TaskScheduler: Always remove SchedulerWorker from idle stack on wake up. (Closed)
Patch Set: CR robliao #3 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_impl.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.cc b/base/task_scheduler/scheduler_worker_pool_impl.cc
index e804bbd779ab06f3dd5070d2fcfa9d2fb3103fc0..d0c5dd2a97dedf0522820a2494e61389c0a19536 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl.cc
@@ -435,7 +435,7 @@ void SchedulerWorkerPoolImpl::PostTaskWithSequenceNow(
// Wake up a worker to process |sequence|.
if (worker)
- worker->WakeUp();
+ WakeUpWorker(worker);
else
WakeUpOneWorker();
}
@@ -720,6 +720,12 @@ bool SchedulerWorkerPoolImpl::Initialize(
return !workers_.empty();
}
+void SchedulerWorkerPoolImpl::WakeUpWorker(SchedulerWorker* worker) {
+ DCHECK(worker);
+ RemoveFromIdleWorkersStack(worker);
+ worker->WakeUp();
+}
+
void SchedulerWorkerPoolImpl::WakeUpOneWorker() {
SchedulerWorker* worker;
{
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698