Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2297)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.h

Issue 2414063002: TaskScheduler: Always remove SchedulerWorker from idle stack on wake up. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/task_scheduler/scheduler_worker_pool_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_impl.h
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.h b/base/task_scheduler/scheduler_worker_pool_impl.h
index a621f797a53473b2096170a07689e456d5c3f2de..94998bc7a77bf1809af01bb217a86bbd6050eb4c 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.h
+++ b/base/task_scheduler/scheduler_worker_pool_impl.h
@@ -114,7 +114,11 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
size_t max_threads,
const ReEnqueueSequenceCallback& re_enqueue_sequence_callback);
- // Wakes up the last worker from this worker pool to go idle, if any.
+ // Wakes up |worker| and removes it from the idle stack.
robliao 2016/10/13 17:38:40 Leave both of these comments like they were before
fdoray 2016/10/13 18:46:55 Done.
+ void WakeUpWorker(SchedulerWorker* worker);
+
+ // Wakes up and removes from the idle stack the last worker from this worker
+ // pool to go idle, if any.
void WakeUpOneWorker();
// Adds |worker| to |idle_workers_stack_|.
« no previous file with comments | « no previous file | base/task_scheduler/scheduler_worker_pool_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698