Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2414003002: Move function length tracking from Scope to (Pre)?ParserFormalParameters. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move function length tracking from Scope to (Pre)?ParserFormalParameters. It belongs there more logically. In addition, this is a pre-step needed for preparsing the parameters of a preparsed function. In addition, move the "subtract rest parameter from arity" logic from Parser to (Pre)?ParserFormalParameters. BUG=v8:5515 Committed: https://crrev.com/a726e85fe33e25ed057d76b6b8027ca6094ed9e5 Cr-Commit-Position: refs/heads/master@{#40258}

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : oops cont #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -51 lines) Patch
M src/ast/ast.h View 6 chunks +11 lines, -8 lines 0 comments Download
M src/ast/scopes.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M src/ast/scopes.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.h View 2 chunks +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 8 chunks +8 lines, -14 lines 0 comments Download
M src/parsing/parser-base.h View 6 chunks +23 lines, -6 lines 0 comments Download
M src/parsing/preparser.h View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Toon Verwaest
Very nice cleanup! lgtm. Just remove arity_ from DeclarationScope :)
4 years, 2 months ago (2016-10-13 12:05:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414003002/40001
4 years, 2 months ago (2016-10-13 12:06:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 12:34:42 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 12:35:05 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a726e85fe33e25ed057d76b6b8027ca6094ed9e5
Cr-Commit-Position: refs/heads/master@{#40258}

Powered by Google App Engine
This is Rietveld 408576698