Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2413993003: Add UMA histogram to show how many retries we had to do to execute a DeviceManagementRequestJob. (Closed)

Created:
4 years, 2 months ago by Marton Hunyady
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA histogram to show how many retries we had to do to execute a DeviceManagementRequestJob. BUG=655652 Committed: https://crrev.com/43f6aa3711de2334be84bdf28ec68e9c27d29052 Cr-Commit-Position: refs/heads/master@{#425364}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix histogram summary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M components/policy/core/common/cloud/device_management_service.cc View 4 chunks +30 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Marton Hunyady
PTAL
4 years, 2 months ago (2016-10-13 15:00:42 UTC) #4
Marton Hunyady
jwd: PTAL at histograms.xml
4 years, 2 months ago (2016-10-13 15:17:06 UTC) #6
jwd
https://codereview.chromium.org/2413993003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2413993003/diff/1/tools/metrics/histograms/histograms.xml#newcode12740 tools/metrics/histograms/histograms.xml:12740: + Number of retries the client needed to do ...
4 years, 2 months ago (2016-10-13 19:58:37 UTC) #9
Marton Hunyady
https://codereview.chromium.org/2413993003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2413993003/diff/1/tools/metrics/histograms/histograms.xml#newcode12740 tools/metrics/histograms/histograms.xml:12740: + Number of retries the client needed to do ...
4 years, 2 months ago (2016-10-14 08:40:34 UTC) #10
Andrew T Wilson (Slow)
lgtm
4 years, 2 months ago (2016-10-14 09:18:28 UTC) #11
jwd
lgtm
4 years, 2 months ago (2016-10-14 15:28:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413993003/20001
4 years, 2 months ago (2016-10-14 15:45:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 16:57:50 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:59:36 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43f6aa3711de2334be84bdf28ec68e9c27d29052
Cr-Commit-Position: refs/heads/master@{#425364}

Powered by Google App Engine
This is Rietveld 408576698