Move fxge/android to if(is_android) on build

Move fxge/android to if(is_android) on build

core/fxge/android files all have if _FX_OS_ == _FX_ANDROID_. Instead,
put the files inside if (is_android) on Build.gn. Also, the skia file
is already under if (pdf_use_skia), so the if defined(_SKIA_SUPPORT_)
can be removed.

Committed: https://pdfium.googlesource.com/pdfium/+/11e966a2dd931d4676a1b6a7d074a40dd4c1a5d1

[npm, 2016-10-14 19:07:16]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 19:07:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 19:15:17]

Dry run: This issue passed the CQ dry run.

[npm, 2016-10-14 19:16:12]

Description was changed from

==========
Move fxge/android to if(is_android) on build

core/fxge/android files all have if _FX_OS_ == _FX_ANDROID_. Instead,
put the files inside if (is_android) on Build.gn. Also, the skia file
is already under if (pdf_use_skia), so the if defined(_SKIA_SUPPORT_)
can be removed.
==========

to

==========
Move fxge/android to if(is_android) on build

core/fxge/android files all have if _FX_OS_ == _FX_ANDROID_. Instead,
put the files inside if (is_android) on Build.gn. Also, the skia file
is already under if (pdf_use_skia), so the if defined(_SKIA_SUPPORT_)
can be removed.
==========

[npm, 2016-10-14 19:16:12]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, tsepez@chromium.org

[npm, 2016-10-14 19:16:27]

PTAL

[Lei Zhang, 2016-10-14 19:46:05]

https://codereview.chromium.org/2413983004/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2413983004/diff/20001/BUILD.gn#newcode862
BUILD.gn:862: if (is_android) {
I don't think this is necessary. I believe some default GN rules for directory
names already cover this. i.e. Without this CL, do you see any build artifacts
for these files in your out/ directory?

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
File core/fxge/android/fpf_skiafont.h (right):

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
core/fxge/android/fpf_skiafont.h:11: 
get rid of the blink line now

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
File core/fxge/android/fpf_skiafontmgr.cpp (right):

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
core/fxge/android/fpf_skiafontmgr.cpp:7: #include "core/fxcrt/fx_system.h"
fpf_skiafontmgr.h should come fisrt instead.

[npm, 2016-10-14 20:09:46]

On 2016/10/14 19:46:05, Lei Zhang wrote:
> https://codereview.chromium.org/2413983004/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2413983004/diff/20001/BUILD.gn#newcode862
> BUILD.gn:862: if (is_android) {
> I don't think this is necessary. I believe some default GN rules for directory
> names already cover this. i.e. Without this CL, do you see any build artifacts
> for these files in your out/ directory?
> 
>
https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
> File core/fxge/android/fpf_skiafont.h (right):
> 
>
https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
> core/fxge/android/fpf_skiafont.h:11: 
> get rid of the blink line now
> 
>
https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
> File core/fxge/android/fpf_skiafontmgr.cpp (right):
> 
>
https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
> core/fxge/android/fpf_skiafontmgr.cpp:7: #include "core/fxcrt/fx_system.h"
> fpf_skiafontmgr.h should come fisrt instead.

I didn't see build artifacts before this CL.
Is the rule something like folders containing "android"?
So should I undo the changes in BUILD.gn? Or leave for clarity

[Lei Zhang, 2016-10-14 20:21:33]

On 2016/10/14 20:09:46, npm wrote:
> I didn't see build artifacts before this CL.
> Is the rule something like folders containing "android"?
> So should I undo the changes in BUILD.gn? Or leave for clarity

I would just undo it. It's obvious enough that the build system's simple rules
picked it up.

[npm, 2016-10-17 15:02:25]

PTAL

https://codereview.chromium.org/2413983004/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2413983004/diff/20001/BUILD.gn#newcode862
BUILD.gn:862: if (is_android) {
On 2016/10/14 19:46:05, Lei Zhang wrote:
> I don't think this is necessary. I believe some default GN rules for directory
> names already cover this. i.e. Without this CL, do you see any build artifacts
> for these files in your out/ directory?

I do not

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
File core/fxge/android/fpf_skiafont.h (right):

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
core/fxge/android/fpf_skiafont.h:11: 
On 2016/10/14 19:46:05, Lei Zhang wrote:
> get rid of the blink line now

Done.

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
File core/fxge/android/fpf_skiafontmgr.cpp (right):

https://codereview.chromium.org/2413983004/diff/20001/core/fxge/android/fpf_s...
core/fxge/android/fpf_skiafontmgr.cpp:7: #include "core/fxcrt/fx_system.h"
On 2016/10/14 19:46:05, Lei Zhang wrote:
> fpf_skiafontmgr.h should come fisrt instead.

Done.

[Lei Zhang, 2016-10-17 17:38:49]

lgtm

[npm, 2016-10-17 19:52:15]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:52:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 20:02:31]

Description was changed from

==========
Move fxge/android to if(is_android) on build

core/fxge/android files all have if _FX_OS_ == _FX_ANDROID_. Instead,
put the files inside if (is_android) on Build.gn. Also, the skia file
is already under if (pdf_use_skia), so the if defined(_SKIA_SUPPORT_)
can be removed.
==========

to

==========
Move fxge/android to if(is_android) on build

core/fxge/android files all have if _FX_OS_ == _FX_ANDROID_. Instead,
put the files inside if (is_android) on Build.gn. Also, the skia file
is already under if (pdf_use_skia), so the if defined(_SKIA_SUPPORT_)
can be removed.

Committed:
https://pdfium.googlesource.com/pdfium/+/11e966a2dd931d4676a1b6a7d074a40dd4c1...
==========

[commit-bot: I haz the power, 2016-10-17 20:02:32]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/11e966a2dd931d4676a1b6a7d074a40dd4c1...