Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2413943002: [inspector] Record EvaluateScript trace event upon console evaluation (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
caseq, dgozman, paulirish
CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Committed: https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7 Cr-Original-Commit-Position: refs/heads/master@{#40289} Cr-Commit-Position: refs/heads/master@{#40323}

Patch Set 1 #

Patch Set 2 : CL for v8 perf tryjob to run speedometer benchmark on linux platform(s) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/inspector/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M src/inspector/v8-runtime-agent-impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
alph
ptal
4 years, 2 months ago (2016-10-13 01:03:41 UTC) #2
caseq
lgtm
4 years, 2 months ago (2016-10-13 01:06:14 UTC) #6
alph
CL for v8 perf tryjob to run speedometer benchmark on linux platform(s)
4 years, 2 months ago (2016-10-13 01:18:43 UTC) #7
alph
Dima, could you please?
4 years, 2 months ago (2016-10-13 20:11:55 UTC) #11
dgozman
lgtm
4 years, 2 months ago (2016-10-13 20:47:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413943002/20001
4 years, 2 months ago (2016-10-13 21:32:56 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 21:57:36 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289}
4 years, 2 months ago (2016-10-13 21:57:55 UTC) #19
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2416213002/ by machenbach@chromium.org. ...
4 years, 2 months ago (2016-10-14 08:51:10 UTC) #20
alph
Layout tests should now be prepared for the change. Relanding.
4 years, 2 months ago (2016-10-14 19:02:15 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413943002/20001
4 years, 2 months ago (2016-10-14 19:02:31 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 19:04:50 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:05:22 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7
Cr-Commit-Position: refs/heads/master@{#40323}

Powered by Google App Engine
This is Rietveld 408576698