|
|
Description[inspector] Record EvaluateScript trace event upon console evaluation
It will allow timeline to show JS profile on code evaluated from console.
BUG=chromium:655430
Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172
Committed: https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7
Cr-Original-Commit-Position: refs/heads/master@{#40289}
Cr-Commit-Position: refs/heads/master@{#40323}
Patch Set 1 #Patch Set 2 : CL for v8 perf tryjob to run speedometer benchmark on linux platform(s) #
Messages
Total messages: 28 (15 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org, paulirish@chromium.org
ptal
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. ==========
alph@chromium.org changed reviewers: + dgozman@chromium.org
caseq@chromium.org changed reviewers: - dgozman@chromium.org
lgtm
CL for v8 perf tryjob to run speedometer benchmark on linux platform(s)
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=655430 ==========
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=655430 ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 ==========
alph@chromium.org changed reviewers: + dgozman@chromium.org
Dima, could you please?
lgtm
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2413943002/#ps20001 (title: "CL for v8 perf tryjob to run speedometer benchmark on linux platform(s)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2416213002/ by machenbach@chromium.org. The reason for reverting is: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui... See also: https://github.com/v8/v8/wiki/Blink-layout-tests.
Message was sent while issue was closed.
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289} ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289} ==========
Layout tests should now be prepared for the change. Relanding.
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289} ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Cr-Commit-Position: refs/heads/master@{#40289} ========== to ========== [inspector] Record EvaluateScript trace event upon console evaluation It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Committed: https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7 Cr-Original-Commit-Position: refs/heads/master@{#40289} Cr-Commit-Position: refs/heads/master@{#40323} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7 Cr-Commit-Position: refs/heads/master@{#40323} |