ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm - Issue 2413923002: Enable lost URL detection in the Physical Web scanner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm

Issue 2413923002: Enable lost URL detection in the Physical Web scanner (Closed)

Patch Set: fix bug, remove AllowDuplicates, fix nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm

diff --git a/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm b/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm

index 41ce75763a7144104d88c660a349203692f862c8..12edafa0a6d3178384cd40a280c991762cbeffec 100644

--- a/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm

+++ b/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm

@@ -26,6 +26,9 @@ void IOSChromePhysicalWebDataSource::StartDiscovery(

[scanner_ stop];

scanner_.reset([[PhysicalWebScanner alloc] initWithDelegate:nil]);

+ // Configure the scanner to notify us when a URL is no longer nearby.

+ [scanner_ setOnLostDetectionEnabled:YES];

[scanner_ setNetworkRequestEnabled:network_request_enabled];

[scanner_ start];

}

« no previous file with comments | « no previous file | ios/chrome/common/physical_web/physical_web_device.h » ('j') | ios/chrome/common/physical_web/physical_web_scanner.mm » ('J')