Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp - Issue 24139004: Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

Issue 24139004: Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix bad if condition Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

diff --git a/Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp b/Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

index 070963e87e62fc1baaea0670d03846e74983d2e4..04b46fbacb2d34424bff36e197c5ad690502d272 100644

--- a/Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

+++ b/Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

@@ -74,7 +74,7 @@ static void populateContextMenuItems(v8::Local<v8::Array>& itemArray, ContextMen

v8::Local<v8::Value> subItems = item->Get(v8::String::NewSymbol("subItems"));

if (!type->IsString())

continue;

- String typeString = toWebCoreStringWithNullCheck(type);

+ String typeString = toWebCoreStringWithNullCheck(type.As<v8::String>());

if (typeString == "separator") {

ContextMenuItem item(ContextMenuItem(SeparatorType,

ContextMenuItemCustomTagNoAction,

« no previous file with comments | « Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »