Source/bindings/v8/V8Initializer.cpp - Issue 24139004: Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Initializer.cpp

Issue 24139004: Add toWebCoreString() / toWebCoreAtomicString() overloads taking a v8::String (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix bad if condition Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8Initializer.cpp

diff --git a/Source/bindings/v8/V8Initializer.cpp b/Source/bindings/v8/V8Initializer.cpp

index e31c12fbdf4c758df66cdd92e5d085cfadf031f8..8f00688c4185317db513be1c3c83745fcab94f57 100644

--- a/Source/bindings/v8/V8Initializer.cpp

+++ b/Source/bindings/v8/V8Initializer.cpp

@@ -99,7 +99,7 @@ static void messageHandlerInMainThread(v8::Handle<v8::Message> message, v8::Hand

v8::Handle<v8::Value> resourceName = message->GetScriptResourceName();

bool shouldUseDocumentURL = resourceName.IsEmpty() || !resourceName->IsString();

- String resource = shouldUseDocumentURL ? firstWindow->document()->url() : toWebCoreString(resourceName);

+ String resource = shouldUseDocumentURL ? firstWindow->document()->url() : toWebCoreString(resourceName.As<v8::String>());

AccessControlStatus corsStatus = message->IsSharedCrossOrigin() ? SharableCrossOrigin : NotSharableCrossOrigin;

RefPtr<ErrorEvent> event = ErrorEvent::create(errorMessage, resource, message->GetLineNumber(), message->GetStartColumn(), DOMWrapperWorld::current());

« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp » ('j') | no next file with comments »