Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2413883003: Revert of [turbofan] Enable super constructor inlining. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Enable super constructor inlining. (patchset #1 id:1 of https://codereview.chromium.org/2409423006/ ) Reason for revert: As adamk@ pointed out, this is not correct. Some more changes required instead Original issue's description: > [turbofan] Enable super constructor inlining. > > When we inlined a [[Construct]] call to a subclass constructor, we can > also inline the super constructor call (either explicit or implicit), > since we have a concrete JSFunction constant for the subclass and we > can thus constant-fold the %_GetSuperConstructor intrinsic. We don't > need any guards here since the prototype of subclass constructors is > non-writable, non-configurable in ES6. > > BUG=v8:5517 > R=jarin@chromium.org > > Committed: https://crrev.com/74158b00b3f6a1fc8676dd1f7af4d96131eb5ebe > Cr-Commit-Position: refs/heads/master@{#40261} TBR=jarin@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5517 Committed: https://crrev.com/a601eccbde60072b2cbee5292a8e580bae6fd5b9 Cr-Commit-Position: refs/heads/master@{#40285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +8 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of [turbofan] Enable super constructor inlining.
4 years, 2 months ago (2016-10-13 18:03:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413883003/1
4 years, 2 months ago (2016-10-13 18:04:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 18:04:12 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 18:05:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a601eccbde60072b2cbee5292a8e580bae6fd5b9
Cr-Commit-Position: refs/heads/master@{#40285}

Powered by Google App Engine
This is Rietveld 408576698