Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2413863003: [wasm] Stop the BranchTableIterator if there is an error in the decoder. (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Stop the BranchTableIterator if there is an error in the decoder. In a fuzzer testcase I found locally the ast-decoder spent a lot of time in the decoding of kExprBrTable after the decoder already found an error. I did not add a test because the fuzzer test case did not actually crash. It only run out of memory in the chromium fuzzer. R=titzer@chromium.org Committed: https://crrev.com/77bda187a50e2e1cbd26bae86a7cf511c34f0c1a Cr-Commit-Position: refs/heads/master@{#40254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/wasm/ast-decoder.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 2 months ago (2016-10-13 11:26:28 UTC) #1
titzer
lgtm
4 years, 2 months ago (2016-10-13 11:30:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413863003/1
4 years, 2 months ago (2016-10-13 11:56:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 11:58:56 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 11:59:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77bda187a50e2e1cbd26bae86a7cf511c34f0c1a
Cr-Commit-Position: refs/heads/master@{#40254}

Powered by Google App Engine
This is Rietveld 408576698