Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2413823002: Fix file name handling on windows (Closed)

Created:
4 years, 2 months ago by nshahan
Modified:
4 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix file name handling on windows Paths on windows were having the drive letter (ex: c:\) recognized as a URI scheme. Fixes #27450 R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/96f485b075016ea49ad85e145310eed375c98d76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
vsm
lgtm
4 years, 2 months ago (2016-10-12 20:30:27 UTC) #3
nshahan
4 years, 2 months ago (2016-10-12 21:30:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96f485b075016ea49ad85e145310eed375c98d76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698