Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_row.cc

Issue 2413773003: Material Page Info (Views, 3/3): Update site settings section. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_row.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_row.cc b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
index 188e36f4a109eef1d8fb8cc94c8edbde74083268..198fcd11428d89586cda70af92a5eb19f194c04f 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_row.cc
+++ b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
@@ -12,7 +12,6 @@
#include "chrome/browser/ui/website_settings/website_settings_ui.h"
#include "chrome/grit/generated_resources.h"
#include "ui/accessibility/ax_view_state.h"
-#include "ui/base/l10n/l10n_util.h"
#include "ui/base/material_design/material_design_controller.h"
#include "ui/base/models/combobox_model.h"
#include "ui/gfx/image/image.h"
@@ -26,6 +25,11 @@
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
+namespace {
+// Minimum distance between the label and its corresponding menu.
+const int kMinSeparationBetweenLabelAndMenu = 16;
+}
+
namespace internal {
// The |PermissionMenuButton| provides a menu for selecting a setting a
@@ -235,25 +239,15 @@ PermissionSelectorRow::PermissionSelectorRow(
SetLayoutManager(layout);
const int column_set_id = 0;
views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);
- column_set->AddColumn(views::GridLayout::FILL,
- views::GridLayout::FILL,
- 1,
- views::GridLayout::FIXED,
- kPermissionIconColumnWidth,
+ column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 0,
+ views::GridLayout::FIXED, kPermissionIconColumnWidth,
0);
column_set->AddPaddingColumn(0, kPermissionIconMarginLeft);
- column_set->AddColumn(views::GridLayout::FILL,
- views::GridLayout::FILL,
- 1,
- views::GridLayout::USE_PREF,
- 0,
- 0);
- column_set->AddColumn(views::GridLayout::FILL,
- views::GridLayout::FILL,
- 1,
- views::GridLayout::USE_PREF,
- 0,
- 0);
+ column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 0,
+ views::GridLayout::USE_PREF, 0, 0);
+ column_set->AddPaddingColumn(1, kMinSeparationBetweenLabelAndMenu);
+ column_set->AddColumn(views::GridLayout::TRAILING, views::GridLayout::FILL, 0,
+ views::GridLayout::USE_PREF, 0, 0);
layout->StartRow(1, column_set_id);
// Create the permission icon.
@@ -266,9 +260,8 @@ PermissionSelectorRow::PermissionSelectorRow(
views::GridLayout::CENTER,
views::GridLayout::CENTER);
// Create the label that displays the permission type.
- views::Label* label = new views::Label(l10n_util::GetStringFUTF16(
- IDS_WEBSITE_SETTINGS_PERMISSION_TYPE,
- WebsiteSettingsUI::PermissionTypeToUIString(permission.type)));
+ views::Label* label = new views::Label(
+ WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
layout->AddView(label,
1,
1,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698