Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2413773003: Material Page Info (Views, 3/3): Update site settings section. (Closed)

Created:
4 years, 2 months ago by lgarron
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Material Page Info (Views, 3/3): Update site settings section. This includes: - Changing PermissionSelectorRow() to add to a grid layout instead of being its own view. - Renaming some of the views to reflect their current role (cookies_view_, permission_view_, permissions_view_) - Updating a lot of padding values for consistency, and renaming some of them to match the Mac values. BUG=512442 Review-Url: https://codereview.chromium.org/2306673003 Cr-Commit-Position: refs/heads/master@{#424247} (cherry picked from commit c6607f9c83b3c81acb07eb9fc1496dfc814f6a0b) Committed: https://chromium.googlesource.com/chromium/src/+/4425a705f8759d9e77fe50e49407281d7cef3d38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -252 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_row.cc View 4 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 4 chunks +7 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 17 chunks +127 lines, -188 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lgarron
4 years, 2 months ago (2016-10-13 00:59:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4425a705f8759d9e77fe50e49407281d7cef3d38.

Powered by Google App Engine
This is Rietveld 408576698