Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/svg/SVGGeometryElement.idl

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
diff --git a/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl b/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
index 0977d57b02fc804916fd004476127dc63d674719..59d706742adf39c4f921f71701000638256518a4 100644
--- a/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
+++ b/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
@@ -31,7 +31,9 @@
// http://www.w3.org/TR/SVG2/types.html#InterfaceSVGGeometryElement
interface SVGGeometryElement : SVGGraphicsElement {
+ float getTotalLength();
fs 2016/10/24 10:48:53 Could you reorder this so that it matches the spec
Shanmuga Pandi 2016/10/26 09:52:12 I will make a separate patch for 'pathLength'. And
fs 2016/10/26 11:00:03 Acknowledged.
// TODO(foolip): SVGPoint should be DOMPoint.
+ SVGPoint getPointAtLength(float distance);
boolean isPointInFill(SVGPoint point);
boolean isPointInStroke(SVGPoint point);
};

Powered by Google App Engine
This is Rietveld 408576698