Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2413753003:
chrome.gpuBenchmarking.printPagesToXPS (Closed)
|
Created:
4 years, 2 months ago by hal.canary Modified:
4 years, 1 month ago Reviewers:
Ken Russell (switch to Gerrit), bungeman-chromium, Stephen White, bsalomon_chromium, bungeman-skia, Justin Novosad CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionchrome.gpuBenchmarking.printPagesToXPS
BUG=chromium:616763
Committed: https://crrev.com/f35e994096cf339e54acd9b6883b6d3cf1e5b846
Cr-Commit-Position: refs/heads/master@{#429662}
Patch Set 1 #Patch Set 2 : simplify BUILD.gn #Patch Set 3 : rebase #
Total comments: 1
Messages
Total messages: 32 (21 generated)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chrome.gpuBenchmarking.printPagesToXPS BUG= ========== to ========== chrome.gpuBenchmarking.printPagesToXPS BUG= ==========
halcanary@google.com changed reviewers: + bungeman@chromium.org, bungeman@google.com
halcanary@google.com changed reviewers: + kbr@chromium.org
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chrome.gpuBenchmarking.printPagesToXPS BUG= ========== to ========== chrome.gpuBenchmarking.printPagesToXPS BUG=chromium:616763 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
LGTM Going forward, if you don't get a code review within 24 hours or see that the reviewer's OOO per their nickname, please ping or find another reviewer. It's not OK for you to be held up for days at a time.
The CQ bit was checked by halcanary@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2413753003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kbr@chromium.org changed reviewers: + bsalomon@chromium.org, junov@chromium.org, senorblanco@chromium.org
+a few more skia/ owners
lgtm
lgtm
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2413753003/diff/40001/content/renderer/gpu/gp... File content/renderer/gpu/gpu_benchmarking_extension.h (right): https://codereview.chromium.org/2413753003/diff/40001/content/renderer/gpu/gp... content/renderer/gpu/gpu_benchmarking_extension.h:47: void PrintPagesToXPS(v8::Isolate* isolate, Not really new to this patch, but I'm having trouble understanding why this printing functionality is in a class called "GpuBenchmarking". Wat?
Message was sent while issue was closed.
Description was changed from ========== chrome.gpuBenchmarking.printPagesToXPS BUG=chromium:616763 ========== to ========== chrome.gpuBenchmarking.printPagesToXPS BUG=chromium:616763 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== chrome.gpuBenchmarking.printPagesToXPS BUG=chromium:616763 ========== to ========== chrome.gpuBenchmarking.printPagesToXPS BUG=chromium:616763 Committed: https://crrev.com/f35e994096cf339e54acd9b6883b6d3cf1e5b846 Cr-Commit-Position: refs/heads/master@{#429662} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f35e994096cf339e54acd9b6883b6d3cf1e5b846 Cr-Commit-Position: refs/heads/master@{#429662} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
