Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2413743002: Fix a crash where the dragged content does not contain any text. (Closed)

Created:
4 years, 2 months ago by hush (inactive)
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash where the dragged content does not contain any text. The filtered mimetypes array could be null instead of an empty array. We need to check for that. BUG=655081 Committed: https://crrev.com/4bc70d726ec085234f888dd1342dad0108025472 Cr-Commit-Position: refs/heads/master@{#424767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hush (inactive)
Hello Ted, PTAL
4 years, 2 months ago (2016-10-12 15:43:46 UTC) #2
Ted C
lgtm
4 years, 2 months ago (2016-10-12 15:57:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413743002/1
4 years, 2 months ago (2016-10-12 16:23:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 17:05:52 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 17:49:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bc70d726ec085234f888dd1342dad0108025472
Cr-Commit-Position: refs/heads/master@{#424767}

Powered by Google App Engine
This is Rietveld 408576698