third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2413723002: Re-Compute slow scroll region on frameview visibility change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2413723002: Re-Compute slow scroll region on frameview visibility change. (Closed)

Patch Set: modified test case Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html ('K') | « third_party/WebKit/LayoutTests/virtual/rootlayerscrolls/scrollingcoordinator/README.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index d8c6599e5cca8f50180a4cc7c1d0ef73cc436162..b55bcac0167d11404c1b7c61e39bc907d273d244 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -873,7 +873,8 @@ Region ScrollingCoordinator::computeShouldHandleScrollGestureOnMainThreadRegion(

const IntPoint& frameLocation) const {

Region shouldHandleScrollGestureOnMainThreadRegion;

FrameView* frameView = frame->view();

- if (!frameView || frameView->shouldThrottleRendering())

+ if (!frameView || frameView->shouldThrottleRendering() ||

+ !frameView->isVisible())

return shouldHandleScrollGestureOnMainThreadRegion;

IntPoint offset = frameLocation;