Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2413723002: Re-Compute slow scroll region on frameview visibility change. (Closed)
Patch Set: addressed review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index d8c6599e5cca8f50180a4cc7c1d0ef73cc436162..39c1c75ed360613772d3e5072cc9a5cee4f00397 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -131,6 +131,10 @@ void ScrollingCoordinator::notifyOverflowUpdated() {
m_scrollGestureRegionIsDirty = true;
}
+void ScrollingCoordinator::frameViewVisibilityDidChange() {
+ m_scrollGestureRegionIsDirty = true;
+}
+
void ScrollingCoordinator::scrollableAreasDidChange() {
ASSERT(m_page);
if (!m_page->mainFrame()->isLocalFrame() ||
@@ -873,7 +877,8 @@ Region ScrollingCoordinator::computeShouldHandleScrollGestureOnMainThreadRegion(
const IntPoint& frameLocation) const {
Region shouldHandleScrollGestureOnMainThreadRegion;
FrameView* frameView = frame->view();
- if (!frameView || frameView->shouldThrottleRendering())
+ if (!frameView || frameView->shouldThrottleRendering() ||
+ !frameView->isVisible())
return shouldHandleScrollGestureOnMainThreadRegion;
IntPoint offset = frameLocation;
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698