Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2413703002: Sync RTCDataChannel and RTCPeerConnection IDL with spec (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
index 52a5d2c6a33aa7bf4b05f0c4516df62844c16d22..757cb8d6d1be5ad0083caca7579104bcd6d2ff57 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
@@ -114,21 +114,21 @@ enum RTCIceConnectionState {
// https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
// TODO(guidou): The label argument should have [TreatNullAs=EmptyString]
// and be non-nullable.
- [RaisesException] RTCDataChannel createDataChannel([TreatUndefinedAs=NullString] DOMString? label, optional Dictionary options);
+ [CallWith=ExecutionContext, RaisesException] RTCDataChannel createDataChannel([TreatUndefinedAs=NullString] DOMString? label, optional Dictionary options);
attribute EventHandler ondatachannel;
+ // Certificate management
+ // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt
+ [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> generateCertificate(AlgorithmIdentifier keygenAlgorithm);
+
// Non-standard or removed from the spec:
- [CallWith=ExecutionContext, RaisesException] void updateIce(optional Dictionary configuration, optional Dictionary mediaConstraints);
- sequence<MediaStream> getLocalStreams();
- sequence<MediaStream> getRemoteStreams();
- MediaStream getStreamById(DOMString streamId);
- [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
- [RaisesException] void removeStream(MediaStream? stream);
- [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
+ [Measure, RaisesException] void updateIce(optional Dictionary configuration, optional Dictionary mediaConstraints);
+ [Measure] sequence<MediaStream> getLocalStreams();
+ [Measure] sequence<MediaStream> getRemoteStreams();
+ [Measure] MediaStream getStreamById(DOMString streamId);
+ [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
+ [Measure, RaisesException] void removeStream(MediaStream? stream);
+ [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
attribute EventHandler onaddstream;
attribute EventHandler onremovestream;
-
- // Certificate management
- // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt
- [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> generateCertificate(AlgorithmIdentifier keygenAlgorithm);
};
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698