third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2413703002: Sync RTCDataChannel and RTCPeerConnection IDL with spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2413703002: Sync RTCDataChannel and RTCPeerConnection IDL with spec (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index a27b974af1458221401fbdc6c894d55cd5f0106d..ab12e1602e2aa595c800fb0dd2622e8fdf60968d 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -107,8 +107,7 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

String signalingState() const;

- void updateIce(ExecutionContext*,

- const Dictionary& rtcConfiguration,

+ void updateIce(const Dictionary& rtcConfiguration,

const Dictionary& mediaConstraints,

ExceptionState&);

@@ -148,7 +147,8 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

MediaStreamTrack* selector = nullptr);

ScriptPromise getStats(ScriptState*, MediaStreamTrack* selector = nullptr);

- RTCDataChannel* createDataChannel(String label,

+ RTCDataChannel* createDataChannel(ExecutionContext*,

+ String label,

const Dictionary& dataChannelDict,

ExceptionState&);