Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template

Issue 2413693002: Rename DOM.getLayoutTreeNodes to CSS.getLayoutTreeAndStyles (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template b/third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template
index 9555e302a933d0f0a1b561bcc7964e2912df3211..1eae12860f866f98c1a5aca6e0398d09d4c9a191 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template
+++ b/third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template
@@ -42,6 +42,9 @@ public:
return result;
}
+ Array() {}
dgozman 2016/10/12 21:00:40 Why not Array::create() defined above?
alex clarke (OOO till 29th) 2016/10/13 20:25:10 I'm assuming you don't want this to be public?
dgozman 2016/10/14 01:32:33 Yes.
+ explicit Array(std::vector<std::unique_ptr<T>> vector) : m_vector(std::move(vector)) { }
dgozman 2016/10/12 21:00:40 Let's do static std::unique_ptr<Array<T>> fromVect
alex clarke (OOO till 29th) 2016/10/13 20:25:10 Done.
+
void addItem(std::unique_ptr<T> value)
{
m_vector.push_back(std::move(value));

Powered by Google App Engine
This is Rietveld 408576698