Rename DOM.getLayoutTreeNodes to CSS.getLayoutTreeAndStyles

third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_h.template

 // This file is generated
 
 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef {{"_".join(config.protocol.namespace)}}_{{domain.domain}}_h
 #define {{"_".join(config.protocol.namespace)}}_{{domain.domain}}_h
 
 {% if config.protocol.export_header %}
@@ skipping 71 matching lines @@
 
     struct {{config.protocol.export_macro}} {{property.name | to_title_case}}Enum {
         {% for literal in property.enum %}
         static const char* {{literal | dash_to_camelcase}};
         {% endfor %}
     }; // {{property.name | to_title_case}}Enum
       {% endif %}
 
       {% if property.optional %}
     bool has{{property.name | to_title_case}}() { return m_{{property.name}}.isJust(); }
-    {{resolve_type(property).raw_return_type}} get{{property.name | to_title_case}}({{resolve_type(property).raw_pass_type}} defaultValue) { return m_{{property.name}}.isJust() ? m_{{property.name}}.fromJust() : defaultValue; }
+    {{resolve_type(property).raw_return_type}} get{{property.name | to_title_case}}({{resolve_type(property).raw_pass_type}} defaultValue) const { return m_{{property.name}}.isJust() ? m_{{property.name}}.fromJust() : defaultValue; }
       {% else %}
-    {{resolve_type(property).raw_return_type}} get{{property.name | to_title_case}}() { return {{resolve_type(property).to_raw_type % ("m_" + property.name)}}; }
+    const {{resolve_type(property).return_type}}& get{{property.name | to_title_case}}() const { return {{"m_" + property.name}}; }

[dgozman, 2016/10/12 21:00:40]

Could you please describe why this change is needed?

Note this is now reused in v8's code, so similar .get() fixes will be needed
there.

[alex clarke (OOO till 29th), 2016/10/13 20:25:10]

Before my change it returned the object by value incurring a copy.  That's fine
when it's an int, not so nice when it's a string.

I appreciate the complexity with the default value in the clause above.  It's
not nice that one returns a reference where the other doesn't.  It may be
possible to make both return a reference -- I didn't try very hard.

Possible alternatives:

1. Add a new method which returns the reference
2. define bool operator<(...) (so you can put it in a std::map).  Probably too
complex

[dgozman, 2016/10/14 01:32:33]

- Note that Strings are cheap in blink - they are shallow wrappers around
refcounted buffer.
- I don't like two different return types depending on the optionality of the
field.

       {% endif %}
     void set{{property.name | to_title_case}}({{resolve_type(property).pass_type}} value) { m_{{property.name}} = {{resolve_type(property).to_rvalue % "value"}}; }
     {% endfor %}
 
     std::unique_ptr<protocol::DictionaryValue> serialize() const;
     std::unique_ptr<{{type.id}}> clone() const;
     {% if type.exported %}
     {{config.exported.string_out}} toJSONString() const override;
     {% endif %}
 
@@ skipping 176 matching lines @@
     static const char commandPrefix[];
     static const char version[];
 };
 
 } // namespace {{domain.domain}}
 {% for namespace in config.protocol.namespace %}
 } // namespace {{namespace}}
 {% endfor %}
 
 #endif // !defined({{"_".join(config.protocol.namespace)}}_{{domain.domain}}_h)