Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2413683002:
Fix duplicate gpu driver bug workaround ids (Closed)
DescriptionFix duplicate gpu driver bug workaround ids
BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/742630fdfc381feacd3d7669d6cbfeee087c70c7
Cr-Commit-Position: refs/heads/master@{#425247}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix duplicate gpu driver bug workaround id #Patch Set 3 : update version #Messages
Total messages: 18 (9 generated)
Description was changed from ========== Cleanup gpu driver bug workaround ids BUG=429053 ========== to ========== Cleanup gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
qiankun.miao@intel.com changed reviewers: + kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org
https://codereview.chromium.org/2413683002/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (left): https://codereview.chromium.org/2413683002/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:2039: "id": 191, Initial intent of this CL was to fix the duplicate id.
On 2016/10/12 14:08:14, qiankun wrote: > https://codereview.chromium.org/2413683002/diff/1/gpu/config/gpu_driver_bug_l... > File gpu/config/gpu_driver_bug_list_json.cc (left): > > https://codereview.chromium.org/2413683002/diff/1/gpu/config/gpu_driver_bug_l... > gpu/config/gpu_driver_bug_list_json.cc:2039: "id": 191, > Initial intent of this CL was to fix the duplicate id. We can't change the entry ids because that will mess up of our histograms - we will be confused which workarounds and how often are they triggered.
Description was changed from ========== Cleanup gpu driver bug workaround ids BUG=429053 ========== to ========== Cleanup gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2016/10/12 14:49:44, Zhenyao Mo wrote: > On 2016/10/12 14:08:14, qiankun wrote: > > > https://codereview.chromium.org/2413683002/diff/1/gpu/config/gpu_driver_bug_l... > > File gpu/config/gpu_driver_bug_list_json.cc (left): > > > > > https://codereview.chromium.org/2413683002/diff/1/gpu/config/gpu_driver_bug_l... > > gpu/config/gpu_driver_bug_list_json.cc:2039: "id": 191, > > Initial intent of this CL was to fix the duplicate id. > > We can't change the entry ids because that will mess up of our histograms - we > will be confused which workarounds and how often are they triggered. I see. Thanks for reminding. Updated this CL.
LGTM Thanks for fixing this. We probably should have a unittest to make sure no two entries share the same ID.
On 2016/10/13 17:40:07, Zhenyao Mo wrote: > LGTM > Thanks for fixing this. We probably should have a unittest to make sure no two > entries share the same ID. I add this task to my todo. I may have time to work on this next week.
The CQ bit was checked by qiankun.miao@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Cleanup gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix duplicate gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by qiankun.miao@intel.com
The CQ bit was checked by qiankun.miao@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix duplicate gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix duplicate gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix duplicate gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix duplicate gpu driver bug workaround ids BUG=429053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/742630fdfc381feacd3d7669d6cbfeee087c70c7 Cr-Commit-Position: refs/heads/master@{#425247} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/742630fdfc381feacd3d7669d6cbfeee087c70c7 Cr-Commit-Position: refs/heads/master@{#425247} |
