Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2413673002: Mark ParseInfo as eval in the constructors (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark ParseInfo as eval in the constructors BUG=v8:5501 Committed: https://crrev.com/d3d64736f7b28dbb909f9c621c86760e3b7db43f Cr-Commit-Position: refs/heads/master@{#40227}

Patch Set 1 #

Patch Set 2 : remove branches #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M src/compiler.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M src/parsing/parse-info.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-12 11:31:55 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-12 12:10:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413673002/40001
4 years, 2 months ago (2016-10-12 14:04:13 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-12 14:28:56 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 14:29:10 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d3d64736f7b28dbb909f9c621c86760e3b7db43f
Cr-Commit-Position: refs/heads/master@{#40227}

Powered by Google App Engine
This is Rietveld 408576698