Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)
Patch Set: Ignore PlzNavigate Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index b6ae5c7d0bdf999e8ea87b749888a5a40149e608..fff2f9f0dd678ce8899dbbb1880be185baae6e82 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -6,6 +6,7 @@
#define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
#include <memory>
+#include <string>
#include "content/common/content_export.h"
#include "content/public/browser/navigation_throttle.h"
@@ -21,6 +22,7 @@ class HttpResponseHeaders;
} // namespace net
namespace content {
+struct GlobalRequestID;
class NavigationData;
class NavigationThrottle;
class RenderFrameHost;
@@ -183,6 +185,11 @@ class CONTENT_EXPORT NavigationHandle {
virtual void CancelDeferredNavigation(
NavigationThrottle::ThrottleCheckResult result) = 0;
+ // Returns the ID of the MAIN_FRAME URLRequest associated with this
clamy 2016/11/09 16:06:53 This is valid for subframes as well. I think we ca
Not at Google. Contact bengr 2016/11/09 22:30:01 Done.
+ // navigation. Can only be called from NavigationThrottle::WillProcessResponse
+ // and WebContentsObserver::ReadyToCommitNavigation.
clamy 2016/11/09 16:06:53 Can you add something like: "Note: in the case of
Not at Google. Contact bengr 2016/11/09 22:30:01 Done.
+ virtual const GlobalRequestID& GetGlobalRequestID() = 0;
+
// Testing methods ----------------------------------------------------------
//
// The following methods should be used exclusively for writing unit tests.

Powered by Google App Engine
This is Rietveld 408576698