Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)
Patch Set: Add comments. Relocate method. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 66bfc536169d1359f3c18ef42abe691f3b1bd08a..537e5f6d622e155e126b7d63af342d7eaf7067ac 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -4,8 +4,6 @@
#include "content/browser/frame_host/navigation_handle_impl.h"
-#include <utility>
-
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "content/browser/browsing_data/clear_site_data_throttle.h"
@@ -203,6 +201,10 @@ bool NavigationHandleImpl::IsExternalProtocol() {
return is_external_protocol_;
}
+bool NavigationHandleImpl::HasNetworkResponseStarted() {
+ return state_ >= WILL_PROCESS_RESPONSE;
+}
+
net::Error NavigationHandleImpl::GetNetErrorCode() {
return net_error_code_;
}
@@ -363,6 +365,11 @@ NavigationData* NavigationHandleImpl::GetNavigationData() {
return navigation_data_.get();
}
+const GlobalRequestID& NavigationHandleImpl::GetGlobalRequestID() {
+ DCHECK_GE(state_, WILL_PROCESS_RESPONSE);
clamy 2016/11/04 14:44:17 This should be changed to DCHECK(state_ == WILL_PR
Not at Google. Contact bengr 2016/11/07 22:17:18 Done.
+ return request_id_;
+}
+
void NavigationHandleImpl::InitServiceWorkerHandle(
ServiceWorkerContextWrapper* service_worker_context) {
DCHECK(IsBrowserSideNavigationEnabled());

Powered by Google App Engine
This is Rietveld 408576698