Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)
Patch Set: Add frame map Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 1c65544982e749b10cb22f40a019ac4e800e5ef4..96d37bb07366f8aa26fe3dd9500db7c8eca4a38b 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -6,8 +6,10 @@
#define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
#include <memory>
+#include <string>
#include "content/common/content_export.h"
+#include "content/public/browser/global_request_id.h"
RyanSturm 2016/10/27 22:41:21 nit: can you forward declare this instead?
Not at Google. Contact bengr 2016/10/28 18:43:33 Done.
#include "content/public/browser/navigation_throttle.h"
#include "content/public/common/referrer.h"
#include "net/base/net_errors.h"
@@ -181,6 +183,12 @@ class CONTENT_EXPORT NavigationHandle {
virtual void CancelDeferredNavigation(
NavigationThrottle::ThrottleCheckResult result) = 0;
+ virtual bool HasNetworkResponseStarted() const = 0;
+
+ // This is valid after the network response has started. Returns the ID of the
+ // MAIN_FRAME URLRequest associated with this navigation.
+ virtual const GlobalRequestID& GetGlobalRequestID() const = 0;
RyanSturm 2016/10/27 22:41:21 const isn't allowed in content/public for the most
Not at Google. Contact bengr 2016/10/28 18:43:33 Done. There is already a const method in this fi
+
// Testing methods ----------------------------------------------------------
//
// The following methods should be used exclusively for writing unit tests.

Powered by Google App Engine
This is Rietveld 408576698