Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2413653006: [turbofan] Modifies the --turbo-verify-machine-graph flag to act as a filter. (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Modifies the --turbo-verify-machine-graph flag to act as a filter. This allows people writing code stubs to just verify the graph of the stub they're working on, at least until we fix all of the issues we have and enable the verification by default. Also fixes representations in CodeStubAssembler::SmiOr and InterpreterAssembler::StarDispatchLookahead. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/36532619314e0bae390c379724aba089fa33675a Cr-Commit-Position: refs/heads/master@{#40320}

Patch Set 1 #

Patch Set 2 : Fixes interpreter unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/code-stub-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
epertoso
4 years, 2 months ago (2016-10-14 09:44:22 UTC) #5
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-14 09:45:13 UTC) #6
mythria
great, lgtm.
4 years, 2 months ago (2016-10-14 09:49:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413653006/20001
4 years, 2 months ago (2016-10-14 13:54:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 14:22:22 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 14:22:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36532619314e0bae390c379724aba089fa33675a
Cr-Commit-Position: refs/heads/master@{#40320}

Powered by Google App Engine
This is Rietveld 408576698