Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2413653003: [stubs] Drop StoreICStub and StoreICTrampolineStub (the non-TurboFan implementations of StoreIC dis… (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Drop StoreICStub and StoreICTrampolineStub (the non-TurboFan implementations of StoreIC dispatchers). Because of the planned improvements of IC system it does not make sense to keep the old platform version of the stub around. Committed: https://crrev.com/3285b9650651a56bb051d05a0a899bc7ff5f95d0 Cr-Commit-Position: refs/heads/master@{#40216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -594 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/code-factory.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M src/code-stubs.h View 6 chunks +12 lines, -45 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -70 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +0 lines, -70 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-12 10:15:15 UTC) #4
Jakob Kummerow
Delete ALL the code! :-) LGTM.
4 years, 2 months ago (2016-10-12 12:02:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413653003/1
4 years, 2 months ago (2016-10-12 12:47:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 12:52:20 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 12:52:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3285b9650651a56bb051d05a0a899bc7ff5f95d0
Cr-Commit-Position: refs/heads/master@{#40216}

Powered by Google App Engine
This is Rietveld 408576698