Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2413653002: Use NullAudioSink in WebMediaPlayerImpl if the audio sink is not OK. (Closed)

Created:
4 years, 2 months ago by Guido Urdaneta
Modified:
4 years, 2 months ago
Reviewers:
chcunningham, o1ka
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NullAudioSink in WebMediaPlayerImpl if the audio sink is not OK. This implements the recommendation given in http://crbug.com/626862#c16 BUG=626862 Committed: https://crrev.com/36e6930d420b5549b3dfdde51ae22da03b3a01ff Cr-Commit-Position: refs/heads/master@{#424982}

Patch Set 1 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Guido Urdaneta
Hi, PTAL
4 years, 2 months ago (2016-10-12 09:34:07 UTC) #3
o1ka
On 2016/10/12 09:34:07, Guido Urdaneta wrote: > Hi, PTAL LGTM - thanks for doing that!
4 years, 2 months ago (2016-10-12 09:36:01 UTC) #4
chcunningham
lgtm
4 years, 2 months ago (2016-10-12 23:46:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413653002/20001
4 years, 2 months ago (2016-10-13 08:23:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-13 08:27:46 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 08:30:19 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36e6930d420b5549b3dfdde51ae22da03b3a01ff
Cr-Commit-Position: refs/heads/master@{#424982}

Powered by Google App Engine
This is Rietveld 408576698